Allow configuring subtasks to always show testcases.#1677
Allow configuring subtasks to always show testcases.#1677veluca93 merged 1 commit intocms-dev:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1677 +/- ##
==========================================
+ Coverage 54.68% 54.71% +0.02%
==========================================
Files 336 336
Lines 27439 27464 +25
==========================================
+ Hits 15006 15026 +20
- Misses 12433 12438 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also defines a new (optional) format for parameters for ScoreTypeGroup. Also allows specifying testcases by lists instead of by regex.
veluca93
force-pushed
the
always_show_testcases
branch
from
b183593 to
7274ee0
Compare
This includes allowing to configure per-subtask "always show testcases" introduced in cms-dev/cms#1677.
prandla
left a comment
prandla
left a comment
There was a problem hiding this comment.
Some philosophical comments regarding type hints.
The implementation itself looks fine.
|
I also briefly considered whether we should drop support for the list-based format entirely (at least within cms.grading.scoretypes) and convert the lists to dicts in the importers / a db updater, but it'd probably end up being more effort in total. that would probably also be more disruptive to forks with custom scoretypes. |
Agreed, I really don't like the "list of arbitrary parameters" approach, but I figure maintaining backwards compatibility is important here. |
2 participants
Also defines a new (optional) format for parameters for ScoreTypeGroup.